[jira] [Created] (ISIS-2043) Allow domain events to be specified at @DomainObject, and make mixins aware of this.

[Dan Haywood (JIRA)]

Dan Haywood created ISIS-2043:
---------------------------------

Summary: Allow domain events to be specified at @DomainObject, and make mixins aware of this.
Key: ISIS-2043
URL: https://issues.apache.org/jira/browse/ISIS-2043
Project: Isis
Issue Type: New Feature
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Fix For: 1.16.3


Thus:
{code:java}
@DomainObject(
...,
actionDomainEvent=IncomingInvoice.ActionDomainEvent.class,
propertyDomainEvent=IncomingInvoice.PropertyDomainEvent.class,
collectionDomainEVent=IncomingInvoice.CollectionDomainEvent.class
)
public class IncomingInvoice {
public static class ActionDomainEvent
extends o.a.i.applib.services.eventbus.ActionDomainEvent {}
// etc
}{code}
then, for this domain event would be used as the default for any actions etc.

Two refinements to this:

a) for mixins, the event type emitted by a mixin action should be that of its mixee if possible.  This does mean that the domain event must use <Object> as its generic type, because the source could either be the regular domain object or a mixin.  This seems reasonable, the subscriber can just call ev.getMixee() to determine the original source.

b) as a metamodel validation, if there are members that already define their own event types, then these event types should inherit from the types defined in @DomainObject.  However, not sure exactly how well this plays with requirement from (a) that the generic type is <Object>.

 

 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ASF subversion and git services (JIRA)]

[ https://issues.apache.org/jira/browse/ISIS-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696506#comment-16696506 ]

ASF subversion and git services commented on ISIS-2043:
-------------------------------------------------------

Commit cab9e464aa0b9661ada58ab3a0f9b2512afc63d0 in isis's branch refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=cab9e46 ]

ISIS-2043: adds ActionDomainEvent#getSubject() as a convenience

------------------------------------------------------------------------------------
Key: ISIS-2043
URL: https://issues.apache.org/jira/browse/ISIS-2043
Project: Isis
Issue Type: New Feature
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Major
Fix For: 1.16.3
{code:java}
@DomainObject(
...,
actionDomainEvent=IncomingInvoice.ActionDomainEvent.class,
propertyDomainEvent=IncomingInvoice.PropertyDomainEvent.class,
collectionDomainEVent=IncomingInvoice.CollectionDomainEvent.class
)
public class IncomingInvoice {
public static class ActionDomainEvent
extends o.a.i.applib.services.eventbus.ActionDomainEvent {}
// etc
}{code}
then, for this domain event would be used as the default for any actions etc.
a) for mixins, the event type emitted by a mixin action should be that of its mixee if possible.  This does mean that the domain event must use <Object> as its generic type, because the source could either be the regular domain object or a mixin.  This seems reasonable, the subscriber can just call ev.getMixee() to determine the original source.
 
 
 

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ASF subversion and git services (JIRA)]

[ https://issues.apache.org/jira/browse/ISIS-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696507#comment-16696507 ]

ASF subversion and git services commented on ISIS-2043:
-------------------------------------------------------

Commit c568147d62ed6f5519e61051cdc26c6ce4ff83ad in isis's branch refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=c568147 ]

ISIS-2043: adds support for @DomainObject(xxxDomainEvent=...) for mixins

whereby will honour the domain event specified if not otherwise annotated.

In fact, this contains a few other fixes:

* previously, although mixin actions did emit domain events for all phases (hide/disable/validate/executing/executed), mixin properties and mixin collections emitted none. Now this is fixed so that the emit domain events for the first two phases (hide/disable). It doesn't make sense to emit them for the remainder because mixin props/colls are always derived (are read-only queries under the covers).

* also, getMixedIn() now promoted from ActionDomainEvent up to AbstractDomainEvent

* also, added similar getSubject() (a simple wrapper around getSource() and getMixedIn()) also in AbstractDomainEvent.

------------------------------------------------------------------------------------
Key: ISIS-2043
URL: https://issues.apache.org/jira/browse/ISIS-2043
Project: Isis
Issue Type: New Feature
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Major
Fix For: 1.16.3
{code:java}
@DomainObject(
...,
actionDomainEvent=IncomingInvoice.ActionDomainEvent.class,
propertyDomainEvent=IncomingInvoice.PropertyDomainEvent.class,
collectionDomainEVent=IncomingInvoice.CollectionDomainEvent.class
)
public class IncomingInvoice {
public static class ActionDomainEvent
extends o.a.i.applib.services.eventbus.ActionDomainEvent {}
// etc
}{code}
then, for this domain event would be used as the default for any actions etc.
a) for mixins, the event type emitted by a mixin action should be that of its mixee if possible.  This does mean that the domain event must use <Object> as its generic type, because the source could either be the regular domain object or a mixin.  This seems reasonable, the subscriber can just call ev.getMixee() to determine the original source.
 
 
 

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ASF subversion and git services (JIRA)]

[ https://issues.apache.org/jira/browse/ISIS-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696508#comment-16696508 ]

ASF subversion and git services commented on ISIS-2043:
-------------------------------------------------------

Commit 901b63e2236bd93ed3af8a4b5e188dddecd27dd5 in isis's branch refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=901b63e ]

------------------------------------------------------------------------------------
Key: ISIS-2043
URL: https://issues.apache.org/jira/browse/ISIS-2043
Project: Isis
Issue Type: New Feature
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Major
Fix For: 1.16.3
{code:java}
@DomainObject(
...,
actionDomainEvent=IncomingInvoice.ActionDomainEvent.class,
propertyDomainEvent=IncomingInvoice.PropertyDomainEvent.class,
collectionDomainEVent=IncomingInvoice.CollectionDomainEvent.class
)
public class IncomingInvoice {
public static class ActionDomainEvent
extends o.a.i.applib.services.eventbus.ActionDomainEvent {}
// etc
}{code}
then, for this domain event would be used as the default for any actions etc.
a) for mixins, the event type emitted by a mixin action should be that of its mixee if possible.  This does mean that the domain event must use <Object> as its generic type, because the source could either be the regular domain object or a mixin.  This seems reasonable, the subscriber can just call ev.getMixee() to determine the original source.
 
 
 

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ASF subversion and git services (JIRA)]

[ https://issues.apache.org/jira/browse/ISIS-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696505#comment-16696505 ]

ASF subversion and git services commented on ISIS-2043:
-------------------------------------------------------

Commit b9adf68d3cb78424c6c081a95d79911d5692d07c in isis's branch refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=b9adf68 ]

------------------------------------------------------------------------------------
Key: ISIS-2043
URL: https://issues.apache.org/jira/browse/ISIS-2043
Project: Isis
Issue Type: New Feature
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Major
Fix For: 1.16.3
{code:java}
@DomainObject(
...,
actionDomainEvent=IncomingInvoice.ActionDomainEvent.class,
propertyDomainEvent=IncomingInvoice.PropertyDomainEvent.class,
collectionDomainEVent=IncomingInvoice.CollectionDomainEvent.class
)
public class IncomingInvoice {
public static class ActionDomainEvent
extends o.a.i.applib.services.eventbus.ActionDomainEvent {}
// etc
}{code}
then, for this domain event would be used as the default for any actions etc.
a) for mixins, the event type emitted by a mixin action should be that of its mixee if possible.  This does mean that the domain event must use <Object> as its generic type, because the source could either be the regular domain object or a mixin.  This seems reasonable, the subscriber can just call ev.getMixee() to determine the original source.
 
 
 

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ASF subversion and git services (JIRA)]

[ https://issues.apache.org/jira/browse/ISIS-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697117#comment-16697117 ]

ASF subversion and git services commented on ISIS-2043:
-------------------------------------------------------

Commit cab9e464aa0b9661ada58ab3a0f9b2512afc63d0 in isis's branch refs/heads/v2 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=cab9e46 ]

ISIS-2043: adds ActionDomainEvent#getSubject() as a convenience

------------------------------------------------------------------------------------
Key: ISIS-2043
URL: https://issues.apache.org/jira/browse/ISIS-2043
Project: Isis
Issue Type: New Feature
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Major
Fix For: 1.16.3
{code:java}
@DomainObject(
...,
actionDomainEvent=IncomingInvoice.ActionDomainEvent.class,
propertyDomainEvent=IncomingInvoice.PropertyDomainEvent.class,
collectionDomainEVent=IncomingInvoice.CollectionDomainEvent.class
)
public class IncomingInvoice {
public static class ActionDomainEvent
extends o.a.i.applib.services.eventbus.ActionDomainEvent {}
// etc
}{code}
then, for this domain event would be used as the default for any actions etc.
a) for mixins, the event type emitted by a mixin action should be that of its mixee if possible.  This does mean that the domain event must use <Object> as its generic type, because the source could either be the regular domain object or a mixin.  This seems reasonable, the subscriber can just call ev.getMixee() to determine the original source.
 
 
 

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ASF subversion and git services (JIRA)]

[ https://issues.apache.org/jira/browse/ISIS-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697118#comment-16697118 ]

ASF subversion and git services commented on ISIS-2043:
-------------------------------------------------------

Commit c568147d62ed6f5519e61051cdc26c6ce4ff83ad in isis's branch refs/heads/v2 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=c568147 ]

ISIS-2043: adds support for @DomainObject(xxxDomainEvent=...) for mixins

whereby will honour the domain event specified if not otherwise annotated.

In fact, this contains a few other fixes:

* previously, although mixin actions did emit domain events for all phases (hide/disable/validate/executing/executed), mixin properties and mixin collections emitted none. Now this is fixed so that the emit domain events for the first two phases (hide/disable). It doesn't make sense to emit them for the remainder because mixin props/colls are always derived (are read-only queries under the covers).

* also, getMixedIn() now promoted from ActionDomainEvent up to AbstractDomainEvent

* also, added similar getSubject() (a simple wrapper around getSource() and getMixedIn()) also in AbstractDomainEvent.

------------------------------------------------------------------------------------
Key: ISIS-2043
URL: https://issues.apache.org/jira/browse/ISIS-2043
Project: Isis
Issue Type: New Feature
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Major
Fix For: 1.16.3
{code:java}
@DomainObject(
...,
actionDomainEvent=IncomingInvoice.ActionDomainEvent.class,
propertyDomainEvent=IncomingInvoice.PropertyDomainEvent.class,
collectionDomainEVent=IncomingInvoice.CollectionDomainEvent.class
)
public class IncomingInvoice {
public static class ActionDomainEvent
extends o.a.i.applib.services.eventbus.ActionDomainEvent {}
// etc
}{code}
then, for this domain event would be used as the default for any actions etc.
a) for mixins, the event type emitted by a mixin action should be that of its mixee if possible.  This does mean that the domain event must use <Object> as its generic type, because the source could either be the regular domain object or a mixin.  This seems reasonable, the subscriber can just call ev.getMixee() to determine the original source.
 
 
 

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ASF subversion and git services (JIRA)]

[ https://issues.apache.org/jira/browse/ISIS-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697119#comment-16697119 ]

ASF subversion and git services commented on ISIS-2043:
-------------------------------------------------------

Commit 901b63e2236bd93ed3af8a4b5e188dddecd27dd5 in isis's branch refs/heads/v2 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=901b63e ]

------------------------------------------------------------------------------------
Key: ISIS-2043
URL: https://issues.apache.org/jira/browse/ISIS-2043
Project: Isis
Issue Type: New Feature
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Major
Fix For: 1.16.3
{code:java}
@DomainObject(
...,
actionDomainEvent=IncomingInvoice.ActionDomainEvent.class,
propertyDomainEvent=IncomingInvoice.PropertyDomainEvent.class,
collectionDomainEVent=IncomingInvoice.CollectionDomainEvent.class
)
public class IncomingInvoice {
public static class ActionDomainEvent
extends o.a.i.applib.services.eventbus.ActionDomainEvent {}
// etc
}{code}
then, for this domain event would be used as the default for any actions etc.
a) for mixins, the event type emitted by a mixin action should be that of its mixee if possible.  This does mean that the domain event must use <Object> as its generic type, because the source could either be the regular domain object or a mixin.  This seems reasonable, the subscriber can just call ev.getMixee() to determine the original source.
 
 
 

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ASF subversion and git services (JIRA)]

[ https://issues.apache.org/jira/browse/ISIS-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697116#comment-16697116 ]

ASF subversion and git services commented on ISIS-2043:
-------------------------------------------------------

Commit b9adf68d3cb78424c6c081a95d79911d5692d07c in isis's branch refs/heads/v2 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=b9adf68 ]

------------------------------------------------------------------------------------
Key: ISIS-2043
URL: https://issues.apache.org/jira/browse/ISIS-2043
Project: Isis
Issue Type: New Feature
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Major
Fix For: 1.16.3
{code:java}
@DomainObject(
...,
actionDomainEvent=IncomingInvoice.ActionDomainEvent.class,
propertyDomainEvent=IncomingInvoice.PropertyDomainEvent.class,
collectionDomainEVent=IncomingInvoice.CollectionDomainEvent.class
)
public class IncomingInvoice {
public static class ActionDomainEvent
extends o.a.i.applib.services.eventbus.ActionDomainEvent {}
// etc
}{code}
then, for this domain event would be used as the default for any actions etc.
a) for mixins, the event type emitted by a mixin action should be that of its mixee if possible.  This does mean that the domain event must use <Object> as its generic type, because the source could either be the regular domain object or a mixin.  This seems reasonable, the subscriber can just call ev.getMixee() to determine the original source.
 
 
 

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ASF subversion and git services (JIRA)]

[ https://issues.apache.org/jira/browse/ISIS-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697122#comment-16697122 ]

ASF subversion and git services commented on ISIS-2043:
-------------------------------------------------------

Commit e85504a28e2e3da3fb49cfefff8bb3327d7d21e0 in isis's branch refs/heads/v2 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=e85504a ]

ISIS-2043: removes accidentally committed test class

------------------------------------------------------------------------------------
Key: ISIS-2043
URL: https://issues.apache.org/jira/browse/ISIS-2043
Project: Isis
Issue Type: New Feature
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Major
Fix For: 1.16.3
{code:java}
@DomainObject(
...,
actionDomainEvent=IncomingInvoice.ActionDomainEvent.class,
propertyDomainEvent=IncomingInvoice.PropertyDomainEvent.class,
collectionDomainEVent=IncomingInvoice.CollectionDomainEvent.class
)
public class IncomingInvoice {
public static class ActionDomainEvent
extends o.a.i.applib.services.eventbus.ActionDomainEvent {}
// etc
}{code}
then, for this domain event would be used as the default for any actions etc.
a) for mixins, the event type emitted by a mixin action should be that of its mixee if possible.  This does mean that the domain event must use <Object> as its generic type, because the source could either be the regular domain object or a mixin.  This seems reasonable, the subscriber can just call ev.getMixee() to determine the original source.
 
 
 

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ASF subversion and git services (JIRA)]

[ https://issues.apache.org/jira/browse/ISIS-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697884#comment-16697884 ]

ASF subversion and git services commented on ISIS-2043:
-------------------------------------------------------

Commit 901b63e2236bd93ed3af8a4b5e188dddecd27dd5 in isis's branch refs/heads/2039-Redesign_of_Config from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=901b63e ]

------------------------------------------------------------------------------------
Key: ISIS-2043
URL: https://issues.apache.org/jira/browse/ISIS-2043
Project: Isis
Issue Type: New Feature
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Major
Fix For: 1.16.3
{code:java}
@DomainObject(
...,
actionDomainEvent=IncomingInvoice.ActionDomainEvent.class,
propertyDomainEvent=IncomingInvoice.PropertyDomainEvent.class,
collectionDomainEVent=IncomingInvoice.CollectionDomainEvent.class
)
public class IncomingInvoice {
public static class ActionDomainEvent
extends o.a.i.applib.services.eventbus.ActionDomainEvent {}
// etc
}{code}
then, for this domain event would be used as the default for any actions etc.
a) for mixins, the event type emitted by a mixin action should be that of its mixee if possible.  This does mean that the domain event must use <Object> as its generic type, because the source could either be the regular domain object or a mixin.  This seems reasonable, the subscriber can just call ev.getMixee() to determine the original source.
 
 
 

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ASF subversion and git services (JIRA)]

[ https://issues.apache.org/jira/browse/ISIS-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697885#comment-16697885 ]

ASF subversion and git services commented on ISIS-2043:
-------------------------------------------------------

Commit e85504a28e2e3da3fb49cfefff8bb3327d7d21e0 in isis's branch refs/heads/2039-Redesign_of_Config from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=e85504a ]

ISIS-2043: removes accidentally committed test class

------------------------------------------------------------------------------------
Key: ISIS-2043
URL: https://issues.apache.org/jira/browse/ISIS-2043
Project: Isis
Issue Type: New Feature
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Major
Fix For: 1.16.3
{code:java}
@DomainObject(
...,
actionDomainEvent=IncomingInvoice.ActionDomainEvent.class,
propertyDomainEvent=IncomingInvoice.PropertyDomainEvent.class,
collectionDomainEVent=IncomingInvoice.CollectionDomainEvent.class
)
public class IncomingInvoice {
public static class ActionDomainEvent
extends o.a.i.applib.services.eventbus.ActionDomainEvent {}
// etc
}{code}
then, for this domain event would be used as the default for any actions etc.
a) for mixins, the event type emitted by a mixin action should be that of its mixee if possible.  This does mean that the domain event must use <Object> as its generic type, because the source could either be the regular domain object or a mixin.  This seems reasonable, the subscriber can just call ev.getMixee() to determine the original source.
 
 
 

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ASF subversion and git services (JIRA)]

[ https://issues.apache.org/jira/browse/ISIS-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697883#comment-16697883 ]

ASF subversion and git services commented on ISIS-2043:
-------------------------------------------------------

Commit c568147d62ed6f5519e61051cdc26c6ce4ff83ad in isis's branch refs/heads/2039-Redesign_of_Config from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=c568147 ]

ISIS-2043: adds support for @DomainObject(xxxDomainEvent=...) for mixins

whereby will honour the domain event specified if not otherwise annotated.

In fact, this contains a few other fixes:

* previously, although mixin actions did emit domain events for all phases (hide/disable/validate/executing/executed), mixin properties and mixin collections emitted none. Now this is fixed so that the emit domain events for the first two phases (hide/disable). It doesn't make sense to emit them for the remainder because mixin props/colls are always derived (are read-only queries under the covers).

* also, getMixedIn() now promoted from ActionDomainEvent up to AbstractDomainEvent

* also, added similar getSubject() (a simple wrapper around getSource() and getMixedIn()) also in AbstractDomainEvent.

------------------------------------------------------------------------------------
Key: ISIS-2043
URL: https://issues.apache.org/jira/browse/ISIS-2043
Project: Isis
Issue Type: New Feature
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Major
Fix For: 1.16.3
{code:java}
@DomainObject(
...,
actionDomainEvent=IncomingInvoice.ActionDomainEvent.class,
propertyDomainEvent=IncomingInvoice.PropertyDomainEvent.class,
collectionDomainEVent=IncomingInvoice.CollectionDomainEvent.class
)
public class IncomingInvoice {
public static class ActionDomainEvent
extends o.a.i.applib.services.eventbus.ActionDomainEvent {}
// etc
}{code}
then, for this domain event would be used as the default for any actions etc.
a) for mixins, the event type emitted by a mixin action should be that of its mixee if possible.  This does mean that the domain event must use <Object> as its generic type, because the source could either be the regular domain object or a mixin.  This seems reasonable, the subscriber can just call ev.getMixee() to determine the original source.
 
 
 

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ASF subversion and git services (JIRA)]

[ https://issues.apache.org/jira/browse/ISIS-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697881#comment-16697881 ]

ASF subversion and git services commented on ISIS-2043:
-------------------------------------------------------

Commit b9adf68d3cb78424c6c081a95d79911d5692d07c in isis's branch refs/heads/2039-Redesign_of_Config from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=b9adf68 ]

------------------------------------------------------------------------------------
Key: ISIS-2043
URL: https://issues.apache.org/jira/browse/ISIS-2043
Project: Isis
Issue Type: New Feature
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Major
Fix For: 1.16.3
{code:java}
@DomainObject(
...,
actionDomainEvent=IncomingInvoice.ActionDomainEvent.class,
propertyDomainEvent=IncomingInvoice.PropertyDomainEvent.class,
collectionDomainEVent=IncomingInvoice.CollectionDomainEvent.class
)
public class IncomingInvoice {
public static class ActionDomainEvent
extends o.a.i.applib.services.eventbus.ActionDomainEvent {}
// etc
}{code}
then, for this domain event would be used as the default for any actions etc.
a) for mixins, the event type emitted by a mixin action should be that of its mixee if possible.  This does mean that the domain event must use <Object> as its generic type, because the source could either be the regular domain object or a mixin.  This seems reasonable, the subscriber can just call ev.getMixee() to determine the original source.
 
 
 

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ASF subversion and git services (JIRA)]

[ https://issues.apache.org/jira/browse/ISIS-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697882#comment-16697882 ]

ASF subversion and git services commented on ISIS-2043:
-------------------------------------------------------

Commit cab9e464aa0b9661ada58ab3a0f9b2512afc63d0 in isis's branch refs/heads/2039-Redesign_of_Config from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=cab9e46 ]

ISIS-2043: adds ActionDomainEvent#getSubject() as a convenience

------------------------------------------------------------------------------------
Key: ISIS-2043
URL: https://issues.apache.org/jira/browse/ISIS-2043
Project: Isis
Issue Type: New Feature
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Major
Fix For: 1.16.3
{code:java}
@DomainObject(
...,
actionDomainEvent=IncomingInvoice.ActionDomainEvent.class,
propertyDomainEvent=IncomingInvoice.PropertyDomainEvent.class,
collectionDomainEVent=IncomingInvoice.CollectionDomainEvent.class
)
public class IncomingInvoice {
public static class ActionDomainEvent
extends o.a.i.applib.services.eventbus.ActionDomainEvent {}
// etc
}{code}
then, for this domain event would be used as the default for any actions etc.
a) for mixins, the event type emitted by a mixin action should be that of its mixee if possible.  This does mean that the domain event must use <Object> as its generic type, because the source could either be the regular domain object or a mixin.  This seems reasonable, the subscriber can just call ev.getMixee() to determine the original source.
 
 
 

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)