[jira] [Created] (ISIS-561) Now we have support for view models, we could simplify matters elsewhere by removing support for transient objects.

Discussion:

Dan Haywood (JIRA)

2013-10-11 12:39:42 UTC

Permalink

Dan Haywood created ISIS-561:
--------------------------------

Summary: Now we have support for view models, we could simplify matters elsewhere by removing support for transient objects.
Key: ISIS-561
URL: https://issues.apache.org/jira/browse/ISIS-561
Project: Isis
Issue Type: Improvement
Components: Core
Affects Versions: core-1.2.0, viewer-restfulobjects-2.0.0, viewer-wicket-1.2.0
Reporter: Dan Haywood
Assignee: Dan Haywood
Fix For: viewer-wicket-2.0.0, viewer-restfulobjects-2.2.0, core-2.0.0

Some discussion is required before going ahead with this. But it'd be nice to delete a bunch of code... :-)

--
This message was sent by Atlassian JIRA
(v6.1#6144)

Jeroen van der Wal (JIRA)

2013-10-13 20:44:41 UTC

Permalink

[ https://issues.apache.org/jira/browse/ISIS-561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793778#comment-13793778 ]

Jeroen van der Wal commented on ISIS-561:
-----------------------------------------

Deleting code is always good but to me it's not clear why there is a distinction between transient objects and view models in the first place. A view model is in essence a transient object that will never be persisted right?

Post by Dan Haywood (JIRA)
Now we have support for view models, we could simplify matters elsewhere by removing support for transient objects.
-------------------------------------------------------------------------------------------------------------------
Key: ISIS-561
URL: https://issues.apache.org/jira/browse/ISIS-561
Project: Isis
Issue Type: Improvement
Components: Core
Affects Versions: viewer-wicket-1.2.0, viewer-restfulobjects-2.0.0, core-1.2.0
Reporter: Dan Haywood
Assignee: Dan Haywood
Fix For: viewer-wicket-2.0.0, viewer-restfulobjects-2.2.0, core-2.0.0
Some discussion is required before going ahead with this. But it'd be nice to delete a bunch of code... :-)

--
This message was sent by Atlassian JIRA
(v6.1#6144)

Dan Haywood (JIRA)

2013-10-15 06:47:41 UTC

Permalink

[ https://issues.apache.org/jira/browse/ISIS-561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13794937#comment-13794937 ]

Dan Haywood commented on ISIS-561:
----------------------------------

Transient objects have grown to have two separate usages.

The first usage - as you say - is that they act as view models. However, they have had some limitations, in that they rely on the viewer to maintain their identity over time. The DnD viewer and the Scimpi viewer do this, and I might even have written the Wicket viewer to do this also; but the RO viewer does not and cannot do this because it is deliberately stateless. Therefore for RO at least a transient object is a very anaemic view model.

The second usage (and the original one) is that a transient object is a domain entity that hasn't yet been persisted. Hence we have the newTransientInstance(...) followed by persist(...) idiom. Generally though these methods are called in the same action, so separating them seems silly.

Internally, transient objects get their own Oid state, so there's a bunch of logic within the core of Isis to handle them (separate from the logic to handle view models).

--
This message was sent by Atlassian JIRA
(v6.1#6144)

David Tildesley (JIRA)

2013-10-21 21:13:41 UTC

Permalink

[ https://issues.apache.org/jira/browse/ISIS-561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801074#comment-13801074 ]

David Tildesley commented on ISIS-561:
--------------------------------------

view objects belong in the UI layer. domain layer should be independent of UI layer. There is a requirement to have non-persisted domain objects. Persistance is just an injected behaviour to the domain object (save me). Many times a domain graph is created from a system to system interaction (i.e. calling an external service to get information or put information).

--
This message was sent by Atlassian JIRA
(v6.1#6144)

Dan Haywood (JIRA)

2014-03-06 18:52:44 UTC

Permalink

[ https://issues.apache.org/jira/browse/ISIS-561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Haywood updated ISIS-561:
-----------------------------

Fix Version/s: (was: viewer-restfulobjects-2.2.0)
viewer-restfulobjects-2.4.0

Post by Dan Haywood (JIRA)
Now we have support for view models, we could simplify matters elsewhere by removing support for transient objects.
-------------------------------------------------------------------------------------------------------------------
Key: ISIS-561
URL: https://issues.apache.org/jira/browse/ISIS-561
Project: Isis
Issue Type: Improvement
Components: Core
Affects Versions: viewer-wicket-1.2.0, viewer-restfulobjects-2.0.0, core-1.2.0
Reporter: Dan Haywood
Assignee: Dan Haywood
Fix For: viewer-wicket-2.0.0, viewer-restfulobjects-2.4.0, core-2.0.0
Some discussion is required before going ahead with this. But it'd be nice to delete a bunch of code... :-)

--
This message was sent by Atlassian JIRA
(v6.2#6252)

Dan Haywood (JIRA)

2014-09-12 12:58:34 UTC

Permalink

Post by Dan Haywood (JIRA)
Now we have support for view models, we could simplify matters elsewhere by removing support for transient objects.
-------------------------------------------------------------------------------------------------------------------
Key: ISIS-561
URL: https://issues.apache.org/jira/browse/ISIS-561
Project: Isis
Issue Type: Improvement
Components: Core
Affects Versions: viewer-wicket-1.2.0, viewer-restfulobjects-2.0.0, core-1.2.0
Reporter: Dan Haywood
Assignee: Dan Haywood
Fix For: viewer-wicket-2.0.0, core-2.0.0
Some discussion is required before going ahead with this. But it'd be nice to delete a bunch of code... :-)

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Dan Haywood (JIRA)

2018-10-03 11:41:00 UTC

Permalink

Post by Dan Haywood (JIRA)
Now we have support for view models, we could simplify matters elsewhere by removing support for transient objects.
-------------------------------------------------------------------------------------------------------------------
Key: ISIS-561
URL: https://issues.apache.org/jira/browse/ISIS-561
Project: Isis
Issue Type: Improvement
Components: Core
Affects Versions: viewer-wicket-1.2.0, viewer-restfulobjects-2.0.0, core-1.2.0
Reporter: Dan Haywood
Priority: Major
Fix For: 2.0.0-M2
Some discussion is required before going ahead with this. But it'd be nice to delete a bunch of code... :-)

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)