Discussion:
[jira] [Created] (ISIS-1880) New value type needed for internal URLs ?
Andi Huber (JIRA)
7 years ago
Permalink
Andi Huber created ISIS-1880:
--------------------------------

Summary: New value type needed for internal URLs ?
Key: ISIS-1880
URL: https://issues.apache.org/jira/browse/ISIS-1880
Project: Isis
Issue Type: Bug
Components: Core
Affects Versions: 2.0.0-M1
Reporter: Andi Huber


The framework in prototyping mode (when rendering domain objects) provides links to swagger and the restful api.

However, this links do not work in general.

Currently these links are contributed by actions that return java.net.URL value types. Which works fine if we want to link to external web-resources. But when linking to internal web-resources its almost impossible to derive the absolute URL a client actually sees.

E.g. we have the relative path to swagger: '/swagger-ui/index.html' but it's impossible to derive the absolute path in general like 'http://some-server:someport:/...'. Not to mention that the servlet container hosting Isis could sit behind a http-reverse-proxy, or that we don't know if the protocol is http or https (SSL could be terminated somewhere else).

And I believe, we should not even have to care!

So I'd propose, we introduce a new value type similar to URL, but one that only represents relative paths within the web-app.

Feel free to comment, if I'm wrong our there is a better solution.







--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Andi Huber (JIRA)
7 years ago
Permalink
[ https://issues.apache.org/jira/browse/ISIS-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andi Huber updated ISIS-1880:
-----------------------------
Fix Version/s: 2.0.0-M1
...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Andi Huber (JIRA)
7 years ago
Permalink
[ https://issues.apache.org/jira/browse/ISIS-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andi Huber reassigned ISIS-1880:
--------------------------------

Assignee: Andi Huber
...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
ASF subversion and git services (JIRA)
7 years ago
Permalink
[ https://issues.apache.org/jira/browse/ISIS-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375807#comment-16375807 ]

ASF subversion and git services commented on ISIS-1880:
-------------------------------------------------------

Commit 91f3d779e8fc40209ba387341c21a8e6f564f09a in isis's branch refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=91f3d77 ]

ISIS-1880 Internal API: allow _Context to override already presnet
singletons
...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
ASF subversion and git services (JIRA)
7 years ago
Permalink
[ https://issues.apache.org/jira/browse/ISIS-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375808#comment-16375808 ]

ASF subversion and git services commented on ISIS-1880:
-------------------------------------------------------

Commit 53f7e3708fd2e3c9fa7cb8037392172fe0c29a8e in isis's branch refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=53f7e37 ]

ISIS-1880 Internal API: null-safe getOrDefault on maps
...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
ASF subversion and git services (JIRA)
7 years ago
Permalink
[ https://issues.apache.org/jira/browse/ISIS-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375809#comment-16375809 ]

ASF subversion and git services commented on ISIS-1880:
-------------------------------------------------------

Commit ed46579232ae58b089768dc35dcb418257891ad3 in isis's branch refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=ed46579 ]

ISIS-1880 Internal API: introduce _Resource for storing application
scoped parameters
...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
ASF subversion and git services (JIRA)
7 years ago
Permalink
[ https://issues.apache.org/jira/browse/ISIS-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375810#comment-16375810 ]

ASF subversion and git services commented on ISIS-1880:
-------------------------------------------------------

Commit 80d47de47c9338607110b31b789d041ed62249a0 in isis's branch refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=80d47de ]

ISIS-1880 introduce new value type LocalResourcePath

like java.net.URL but for web-app internal (context-path relative)
resource links
...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Andi Huber (JIRA)
7 years ago
Permalink
[ https://issues.apache.org/jira/browse/ISIS-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andi Huber resolved ISIS-1880.
------------------------------
Resolution: Fixed

The new value type is
{code:java}
LocalResourcePath
{code}

Fixes (web-app local) broken prototyping links to swagger and restful-api, from within the wicket viewer.
...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
ASF subversion and git services (JIRA)
7 years ago
Permalink
[ https://issues.apache.org/jira/browse/ISIS-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375846#comment-16375846 ]

ASF subversion and git services commented on ISIS-1880:
-------------------------------------------------------

Commit da21d613338773621019f0a75f41c8e7d6332a04 in isis's branch refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=da21d61 ]

ISIS-1880 add path syntax validation
...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Andi Huber (JIRA)
7 years ago
Permalink
[ https://issues.apache.org/jira/browse/ISIS-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andi Huber updated ISIS-1880:
-----------------------------
Summary: LocalResourcePath: new value type for local URLs (was: New value type needed for internal URLs ?)
...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Dan Haywood (JIRA)
7 years ago
Permalink
[ https://issues.apache.org/jira/browse/ISIS-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Haywood closed ISIS-1880.
-----------------------------
...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Loading...