Discussion:
[jira] [Created] (ISIS-1977) Improve flattening for -Drevision=...
Dan Haywood (JIRA)
2018-08-31 23:03:00 UTC
Permalink
Dan Haywood created ISIS-1977:
---------------------------------

Summary: Improve flattening for -Drevision=...
Key: ISIS-1977
URL: https://issues.apache.org/jira/browse/ISIS-1977
Project: Isis
Issue Type: Improvement
Components: Core
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Fix For: 1.16.3


Currently flatten-maven-plugin is inherited from the parent pom to all children, and this results in ,<dependencyManagement> being 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
ASF subversion and git services (JIRA)
2018-08-31 23:47:00 UTC
Permalink
[ https://issues.apache.org/jira/browse/ISIS-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599400#comment-16599400 ]

ASF subversion and git services commented on ISIS-1977:
-------------------------------------------------------

Commit d096480e06000034629cc14b237455a5075b2bf7 in isis's branch refs/heads/maint-1.16.2 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=d096480 ]

ISIS-1977: moves flattening plugin into a profile

and uses a different configuration for pom vs regular jar modules
Post by Dan Haywood (JIRA)
Improve flattening for -Drevision=...
-------------------------------------
Key: ISIS-1977
URL: https://issues.apache.org/jira/browse/ISIS-1977
Project: Isis
Issue Type: Improvement
Components: Core
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Minor
Fix For: 1.16.3
Currently flatten-maven-plugin is inherited from the parent pom to all children, and this results in ,<dependencyManagement> being 
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
ASF subversion and git services (JIRA)
2018-09-13 15:18:00 UTC
Permalink
[ https://issues.apache.org/jira/browse/ISIS-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613632#comment-16613632 ]

ASF subversion and git services commented on ISIS-1977:
-------------------------------------------------------

Commit d096480e06000034629cc14b237455a5075b2bf7 in isis's branch refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=d096480 ]

ISIS-1977: moves flattening plugin into a profile

and uses a different configuration for pom vs regular jar modules
Post by Dan Haywood (JIRA)
Improve flattening for -Drevision=...
-------------------------------------
Key: ISIS-1977
URL: https://issues.apache.org/jira/browse/ISIS-1977
Project: Isis
Issue Type: Improvement
Components: Core
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Minor
Fix For: 1.16.3
Currently flatten-maven-plugin is inherited from the parent pom to all children, and this results in ,<dependencyManagement> being 
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
ASF subversion and git services (JIRA)
2018-09-14 16:12:00 UTC
Permalink
[ https://issues.apache.org/jira/browse/ISIS-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16615036#comment-16615036 ]

ASF subversion and git services commented on ISIS-1977:
-------------------------------------------------------

Commit b88eeaed3a2f42cb3af482ff94dab10a7911d9dc in isis's branch refs/heads/v2 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=b88eeae ]

merge (ISIS-1965 & ISIS-1977) - always run flatten plugin, even if -Drevision is not specified (forward port from master)
Post by Dan Haywood (JIRA)
Improve flattening for -Drevision=...
-------------------------------------
Key: ISIS-1977
URL: https://issues.apache.org/jira/browse/ISIS-1977
Project: Isis
Issue Type: Improvement
Components: Core
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Minor
Fix For: 1.16.3
Currently flatten-maven-plugin is inherited from the parent pom to all children, and this results in ,<dependencyManagement> being 
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
ASF subversion and git services (JIRA)
2018-09-15 17:46:00 UTC
Permalink
[ https://issues.apache.org/jira/browse/ISIS-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16616418#comment-16616418 ]

ASF subversion and git services commented on ISIS-1977:
-------------------------------------------------------

Commit b88eeaed3a2f42cb3af482ff94dab10a7911d9dc in isis's branch refs/heads/ISIS-1976-rethink-object-adapters from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=b88eeae ]

merge (ISIS-1965 & ISIS-1977) - always run flatten plugin, even if -Drevision is not specified (forward port from master)
Post by Dan Haywood (JIRA)
Improve flattening for -Drevision=...
-------------------------------------
Key: ISIS-1977
URL: https://issues.apache.org/jira/browse/ISIS-1977
Project: Isis
Issue Type: Improvement
Components: Core
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Minor
Fix For: 1.16.3
Currently flatten-maven-plugin is inherited from the parent pom to all children, and this results in ,<dependencyManagement> being 
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Dan Haywood (JIRA)
2018-09-29 13:50:00 UTC
Permalink
[ https://issues.apache.org/jira/browse/ISIS-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Haywood updated ISIS-1977:
------------------------------

Notes while trial and error (this was done on incode-platform, but same principles apply for any multi-module project)

1
<configuration>
<flattenMode>bom</flattenMode>
<updatePomFile>true</updatePomFile>
<pomElements>
<parent>resolve</parent>
<name>resolve</name>
<description>resolve</description>
<url>resolve</url>
<scm>resolve</scm>
<developers>resolve</developers>
<properties>resolve</properties>
<dependencyManagement>resolve</dependencyManagement>
<dependencies>resolve</dependencies>
<profiles>resolve</profiles>
</pomElements>
</configuration>

2
<configuration>
<flattenMode>bom</flattenMode>
<updatePomFile>true</updatePomFile>
<!--
<pomElements>
<parent>resolve</parent>
<name>resolve</name>
<description>resolve</description>
<url>resolve</url>
<scm>resolve</scm>
<developers>resolve</developers>
<properties>resolve</properties>
<dependencyManagement>resolve</dependencyManagement>
<dependencies>resolve</dependencies>
<profiles>resolve</profiles>
</pomElements>
-->
</configuration>

3.
<configuration>
<flattenMode>bom</flattenMode>
<updatePomFile>true</updatePomFile>
<pomElements>
<parent>resolve</parent>
</pomElements>
<!--
<name>resolve</name>
<description>resolve</description>
<url>resolve</url>
<scm>resolve</scm>
<developers>resolve</developers>
<properties>resolve</properties>
<dependencyManagement>resolve</dependencyManagement>
<dependencies>resolve</dependencies>
<profiles>resolve</profiles>
-->
</configuration>

4.
<configuration>
<flattenMode>bom</flattenMode>
<updatePomFile>true</updatePomFile>
<pomElements>
<parent>resolve</parent>
<name>resolve</name>
<description>resolve</description>
<url>resolve</url>
<scm>resolve</scm>
<developers>resolve</developers>
<properties>resolve</properties>
</pomElements>
<!--
<dependencyManagement>resolve</dependencyManagement>
<dependencies>resolve</dependencies>
<profiles>resolve</profiles>
-->
</configuration>



7. no real difference from 4 for bom.

<configuration>
<flattenMode>bom</flattenMode>
<updatePomFile>true</updatePomFile>
<pomElements>
<parent>resolve</parent>
<name>resolve</name>
<description>resolve</description>
<url>resolve</url>
<scm>resolve</scm>
<developers>resolve</developers>
<properties>resolve</properties>
<dependencies>resolve</dependencies>
</pomElements>
<!--
<dependencyManagement>resolve</dependencyManagement>
--> <profiles>resolve</profiles>

</configuration>





-----------------------------------------------------------------------------------------------------


5. NO!!
<configuration>
<flattenMode>bom</flattenMode>
<updatePomFile>true</updatePomFile>
<pomElements>
<parent>resolve</parent>
<name>resolve</name>
<description>resolve</description>
<url>resolve</url>
<scm>resolve</scm>
<developers>resolve</developers>
<properties>resolve</properties>
<profiles>resolve</profiles>
</pomElements>
<!--
<dependencyManagement>resolve</dependencyManagement>
<dependencies>resolve</dependencies>
-->
</configuration>


6. NO!!
<configuration>
<flattenMode>bom</flattenMode>
<updatePomFile>true</updatePomFile>
<pomElements>
<parent>resolve</parent>
<name>resolve</name>
<description>resolve</description>
<url>resolve</url>
<scm>resolve</scm>
<developers>resolve</developers>
<properties>resolve</properties>
<dependencyManagement>resolve</dependencyManagement>
</pomElements>
<!--
<dependencies>resolve</dependencies>
--> <profiles>resolve</profiles>

</configuration>


8: same as 2, but -Dflatten (in profile); still only in incode-parent.
- rationale: we don't want regular pom's that inherit from incode-parent to have flattening applied

9: same as 3 but also properties, but in -Dflatten profile.

<configuration>
<flattenMode>bom</flattenMode>
<updatePomFile>true</updatePomFile>
<pomElements>
<parent>resolve</parent>
<properties>resolve</properties>
</pomElements>
<!--
<name>resolve</name>
<description>resolve</description>
<url>resolve</url>
<scm>resolve</scm>
<developers>resolve</developers>
<dependencyManagement>resolve</dependencyManagement>
<dependencies>resolve</dependencies>
<profiles>resolve</profiles>
-->
</configuration>

10: as 9, but removes <properties>. For module-base, configures -Dflatten profile as 'defaults', ie simply:

<configuration>
<flattenMode>defaults</flattenMode>
<updatePomFile>true</updatePomFile>
</configuration>

10 (overwrites above), for module-base, add in: - NO

<configuration>
<flattenMode>defaults</flattenMode>
<updatePomFile>true</updatePomFile>
<pomElements>
<name>resolve</name>
<description>resolve</description>
</pomElements>
</configuration>

11 for module-base, change to bom - NO

<configuration>
<flattenMode>bom</flattenMode>
<updatePomFile>true</updatePomFile>
<pomElements>
<name>resolve</name>
<description>resolve</description>
</pomElements>
</configuration>

-- adds in a url, developers, license, scm, properties

12 for module-base, change to oss - NO

<configuration>
<flattenMode>oss</flattenMode>
<updatePomFile>true</updatePomFile>
<pomElements>
<name>resolve</name>
<description>resolve</description>
</pomElements>
</configuration>

-- removes just properties


13 for module-base, back to bom and add: - YES

<configuration>
<flattenMode>defaults</flattenMode>
<updatePomFile>true</updatePomFile>
<pomElements>
<name>resolve</name>
<description>resolve</description>
<dependencies>resolve</dependencies>
</pomElements>
</configuration>

-- seems to flatten test dependencies also.
Post by Dan Haywood (JIRA)
Improve flattening for -Drevision=...
-------------------------------------
Key: ISIS-1977
URL: https://issues.apache.org/jira/browse/ISIS-1977
Project: Isis
Issue Type: Improvement
Components: Core
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Minor
Fix For: 1.16.3
Currently flatten-maven-plugin is inherited from the parent pom to all children, and this results in ,<dependencyManagement> being 
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Dan Haywood (JIRA)
2018-09-29 14:56:00 UTC
Permalink
[ https://issues.apache.org/jira/browse/ISIS-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Haywood resolved ISIS-1977.
-------------------------------
Resolution: Fixed
Post by Dan Haywood (JIRA)
Improve flattening for -Drevision=...
-------------------------------------
Key: ISIS-1977
URL: https://issues.apache.org/jira/browse/ISIS-1977
Project: Isis
Issue Type: Improvement
Components: Core
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Minor
Fix For: 1.16.3
Currently flatten-maven-plugin is inherited from the parent pom to all children, and this results in ,<dependencyManagement> being 
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
ASF subversion and git services (JIRA)
2018-10-03 13:19:00 UTC
Permalink
[ https://issues.apache.org/jira/browse/ISIS-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636934#comment-16636934 ]

ASF subversion and git services commented on ISIS-1977:
-------------------------------------------------------

Commit 2acb207da7cea0c1fe5fd7c080520a3893d833ff in isis's branch refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=2acb207 ]

ISIS-1977: fixes revision to 1.0.0-SNAPSHOT

Because this then allows the framework to be loaded as a submodule within
an app that also using flattening
Post by Dan Haywood (JIRA)
Improve flattening for -Drevision=...
-------------------------------------
Key: ISIS-1977
URL: https://issues.apache.org/jira/browse/ISIS-1977
Project: Isis
Issue Type: Improvement
Components: Core
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Minor
Fix For: 1.16.3
Currently flatten-maven-plugin is inherited from the parent pom to all children, and this results in ,<dependencyManagement> being 
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
ASF subversion and git services (JIRA)
2018-10-05 12:08:00 UTC
Permalink
[ https://issues.apache.org/jira/browse/ISIS-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639728#comment-16639728 ]

ASF subversion and git services commented on ISIS-1977:
-------------------------------------------------------

Commit 2acb207da7cea0c1fe5fd7c080520a3893d833ff in isis's branch refs/heads/v2 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=2acb207 ]

ISIS-1977: fixes revision to 1.0.0-SNAPSHOT

Because this then allows the framework to be loaded as a submodule within
an app that also using flattening
Post by Dan Haywood (JIRA)
Improve flattening for -Drevision=...
-------------------------------------
Key: ISIS-1977
URL: https://issues.apache.org/jira/browse/ISIS-1977
Project: Isis
Issue Type: Improvement
Components: Core
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Minor
Fix For: 1.16.3
Currently flatten-maven-plugin is inherited from the parent pom to all children, and this results in ,<dependencyManagement> being 
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
ASF subversion and git services (JIRA)
2018-10-19 12:59:00 UTC
Permalink
[ https://issues.apache.org/jira/browse/ISIS-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656777#comment-16656777 ]

ASF subversion and git services commented on ISIS-1977:
-------------------------------------------------------

Commit 204a52de0be1367fa1b763fa6cd0645c8c90fcdf in isis's branch refs/heads/v2 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=204a52d ]

ISIS-1977: further changes to flattening.

for the bill-of-materials, seems that using ${project.version} might
actually work rather than ${isis.version} in the dependencyManagement
section.

say this because did it this way with incode-platform, and (surprisingly)
seemed to work.
Post by Dan Haywood (JIRA)
Improve flattening for -Drevision=...
-------------------------------------
Key: ISIS-1977
URL: https://issues.apache.org/jira/browse/ISIS-1977
Project: Isis
Issue Type: Improvement
Components: Core
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Minor
Fix For: 1.16.3
Currently flatten-maven-plugin is inherited from the parent pom to all children, and this results in ,<dependencyManagement> being 
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Loading...